Add timeout for connection from client to remote process allocator #583
+322
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D78567664 |
…ytorch-labs#583) Summary: Adds a `--timeout` option to RemoteAllocator. This will define the time the allocator will wait for a connection from the client before exiting. The timeout will not hit if it keeps receiving messages or has an active allocation. Current default is 0 (infinite) to keep parity with existing uses. This can be changed in the future. Reviewed By: pablorfb-meta Differential Revision: D78567664
dulinriley
force-pushed
the
export-D78567664
branch
from
98b696f to
6990ac8
Compare
|
This pull request was exported from Phabricator. Differential Revision: D78567664 |
|
This pull request has been merged in ae25cb4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Adds a
--timeoutoption to RemoteAllocator. This will define the time the allocator will waitfor a connection from the client before exiting. The timeout will not hit if it keeps receiving
messages or has an active allocation.
Current default is 0 (infinite) to keep parity with existing uses. This can be changed in
the future.
Reviewed By: pablorfb-meta
Differential Revision: D78567664